PCI Hotplug: cpqhp_pushbutton_thread(): remove a pointless if() check
The Coverity checker spotted that we'd have already oops'ed if "ctrl" was NULL. Additionally, "func" had just been checked for not being NULL. Signed-off-by: Adrian Bunk <bunk@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This commit is contained in:
parent
d73460d79b
commit
0039541088
|
@ -1931,16 +1931,14 @@ void cpqhp_pushbutton_thread(unsigned long slot)
|
|||
return ;
|
||||
}
|
||||
|
||||
if (func != NULL && ctrl != NULL) {
|
||||
if (cpqhp_process_SS(ctrl, func) != 0) {
|
||||
amber_LED_on (ctrl, hp_slot);
|
||||
green_LED_on (ctrl, hp_slot);
|
||||
|
||||
set_SOGO(ctrl);
|
||||
if (cpqhp_process_SS(ctrl, func) != 0) {
|
||||
amber_LED_on(ctrl, hp_slot);
|
||||
green_LED_on(ctrl, hp_slot);
|
||||
|
||||
/* Wait for SOBS to be unset */
|
||||
wait_for_ctrl_irq (ctrl);
|
||||
}
|
||||
set_SOGO(ctrl);
|
||||
|
||||
/* Wait for SOBS to be unset */
|
||||
wait_for_ctrl_irq(ctrl);
|
||||
}
|
||||
|
||||
p_slot->state = STATIC_STATE;
|
||||
|
|
Loading…
Reference in New Issue