gpio: Convert gpio_is_valid to return bool
Make the code a bit more readable. Instead of casting an int to an unsigned then comparing to MAX_NR_GPIOS, add a >= 0 test and let the compiler optimizer do the conversion to unsigned. The generated code should be the same. Signed-off-by: Joe Perches <joe@perches.com> Acked-by: Linus Walleij <linus.walleij@linaro.org> Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
This commit is contained in:
parent
82ab0f75ee
commit
3474cb3cc0
|
@ -35,9 +35,9 @@
|
|||
* platform data and other tables.
|
||||
*/
|
||||
|
||||
static inline int gpio_is_valid(int number)
|
||||
static inline bool gpio_is_valid(int number)
|
||||
{
|
||||
return ((unsigned)number) < ARCH_NR_GPIOS;
|
||||
return number >= 0 && number < ARCH_NR_GPIOS;
|
||||
}
|
||||
|
||||
struct device;
|
||||
|
@ -212,7 +212,7 @@ extern void gpio_unexport(unsigned gpio);
|
|||
|
||||
#else /* !CONFIG_GPIOLIB */
|
||||
|
||||
static inline int gpio_is_valid(int number)
|
||||
static inline bool gpio_is_valid(int number)
|
||||
{
|
||||
/* only non-negative numbers are valid */
|
||||
return number >= 0;
|
||||
|
|
|
@ -25,9 +25,9 @@ struct gpio_chip;
|
|||
* warning when something is wrongly called.
|
||||
*/
|
||||
|
||||
static inline int gpio_is_valid(int number)
|
||||
static inline bool gpio_is_valid(int number)
|
||||
{
|
||||
return 0;
|
||||
return false;
|
||||
}
|
||||
|
||||
static inline int gpio_request(unsigned gpio, const char *label)
|
||||
|
|
Loading…
Reference in New Issue