500b4ac90d
On Mon, 2010-05-17 at 17:34 +0200, Mark Brown wrote: > This doesn't seem like the right error handling - if the driver has a > set_mode() you'd *expect* it to have a get_mode() but there's no need > for it to be a strict requirement. True. In such a case, even a valid request would be lost! So now in the updated patch: - check if get_mode is present to avoid oops; - if get_mode is not present, proceed anyways for the request. Here is the updated patch: >From bad0d5eb51ef84be5b100e3dd0f5a590ea0529b6 Mon Sep 17 00:00:00 2001 From: Sundar R Iyer <sundar.iyer@stericsson.com> Date: Fri, 14 May 2010 15:14:17 +0530 Subject: [PATCH 1/1] regulator: return set_mode when same mode is requested save I/O costs by returning when the same mode is requested for the regulator Cc: Liam Girdwood <lrg@slimlogic.co.uk> Cc: Mark Brown <broonie@opensource.wolfsonmicro.com> Acked-by: Linus Walleij <linus.walleij@stericsson.com> Signed-off-by: Sundar R Iyer <sundar.iyer@stericsson.com> Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com> Signed-off-by: Liam Girdwood <lrg@slimlogic.co.uk> |
||
|---|---|---|
| .. | ||
| 88pm8607.c | ||
| Kconfig | ||
| Makefile | ||
| ab3100.c | ||
| bq24022.c | ||
| core.c | ||
| da903x.c | ||
| dummy.c | ||
| dummy.h | ||
| fixed.c | ||
| lp3971.c | ||
| max1586.c | ||
| max8649.c | ||
| max8660.c | ||
| max8925-regulator.c | ||
| mc13783-regulator.c | ||
| pcap-regulator.c | ||
| pcf50633-regulator.c | ||
| tps6507x-regulator.c | ||
| tps65023-regulator.c | ||
| twl-regulator.c | ||
| userspace-consumer.c | ||
| virtual.c | ||
| wm831x-dcdc.c | ||
| wm831x-isink.c | ||
| wm831x-ldo.c | ||
| wm8350-regulator.c | ||
| wm8400-regulator.c | ||
| wm8994-regulator.c | ||