OpenSDV
/
original_kernel
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

ASoC: amd: ps: Fix extraneous error messages 

On Pink Sardine machines that don't have SdW controllers in use, the property
`mipi-sdw-manager-list` won't exist.  There is no point in showing an error
to a user when this situation is encountered.

Furthermore if the machine doesn't have a DMIC connected to the ACP, there
may be no platform devices created either.

Downgrade the associated message to debug.

Fixes: d1351c30ac ("ASoC: amd: ps: create platform devices based on acp config")
Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
Link: https://lore.kernel.org/r/20230708025208.54272-1-mario.limonciello@amd.com
Signed-off-by: Mark Brown <broonie@kernel.org>
This commit is contained in:
Mario Limonciello 2023-07-07 21:52:08 -05:00 committed by Mark Brown
parent 86867aca73
commit cd710900ed
No known key found for this signature in database
GPG Key ID: 24D68B725D5487D0
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
sound/soc/amd/ps/pci-ps.c
View File

@ -257,7 +257,7 @@ static int sdw_amd_scan_controller(struct device *dev)
&sdw_manager_bitmap, 1); &sdw_manager_bitmap, 1);
if (ret) { if (ret) {
dev_err(dev, "Failed to read mipi-sdw-manager-list: %d\n", ret); dev_dbg(dev, "Failed to read mipi-sdw-manager-list: %d\n", ret);
return -EINVAL; return -EINVAL;
} }
count = hweight32(sdw_manager_bitmap); count = hweight32(sdw_manager_bitmap);
@ -641,7 +641,7 @@ static int snd_acp63_probe(struct pci_dev *pci,
ret = get_acp63_device_config(val, pci, adata); ret = get_acp63_device_config(val, pci, adata);
/* ACP PCI driver probe should be continued even PDM or SoundWire Devices are not found */ /* ACP PCI driver probe should be continued even PDM or SoundWire Devices are not found */
if (ret) { if (ret) {
dev_err(&pci->dev, "get acp device config failed:%d\n", ret); dev_dbg(&pci->dev, "get acp device config failed:%d\n", ret);
goto skip_pdev_creation; goto skip_pdev_creation;
} }
ret = create_acp63_platform_devs(pci, adata, addr); ret = create_acp63_platform_devs(pci, adata, addr);