OpenSDV
/
original_kernel
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

ALSA: als100: Fix assignment in if condition 

ISA ALS100 driver code contains lots of assignments in if condition,
which is a bad coding style that may confuse readers and occasionally
lead to bugs.

This patch is merely for coding-style fixes, no functional changes.

Link: https://lore.kernel.org/r/20210608140540.17885-13-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
This commit is contained in:
Takashi Iwai 2021-06-08 16:04:46 +02:00
parent 3e38150bf2
commit ce29edbd26
1 changed files with 12 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
sound/isa/als100.c
View File

@ -177,7 +177,8 @@ static int snd_card_als100_probe(int dev,
return error; return error;
acard = card->private_data; acard = card->private_data;
if ((error = snd_card_als100_pnp(dev, acard, pcard, pid))) { error = snd_card_als100_pnp(dev, acard, pcard, pid);
if (error) {
snd_card_free(card); snd_card_free(card);
return error; return error;
} }
@ -211,12 +212,14 @@ static int snd_card_als100_probe(int dev,
dma16[dev]); dma16[dev]);
} }
if ((error = snd_sb16dsp_pcm(chip, 0)) < 0) { error = snd_sb16dsp_pcm(chip, 0);
if (error < 0) {
snd_card_free(card); snd_card_free(card);
return error; return error;
} }
if ((error = snd_sbmixer_new(chip)) < 0) { error = snd_sbmixer_new(chip);
if (error < 0) {
snd_card_free(card); snd_card_free(card);
return error; return error;
} }
@ -245,18 +248,21 @@ static int snd_card_als100_probe(int dev,
snd_printk(KERN_ERR PFX "no OPL device at 0x%lx-0x%lx\n", snd_printk(KERN_ERR PFX "no OPL device at 0x%lx-0x%lx\n",
fm_port[dev], fm_port[dev] + 2); fm_port[dev], fm_port[dev] + 2);
} else { } else {
if ((error = snd_opl3_timer_new(opl3, 0, 1)) < 0) { error = snd_opl3_timer_new(opl3, 0, 1);
if (error < 0) {
snd_card_free(card); snd_card_free(card);
return error; return error;
} }
if ((error = snd_opl3_hwdep_new(opl3, 0, 1, NULL)) < 0) { error = snd_opl3_hwdep_new(opl3, 0, 1, NULL);
if (error < 0) {
snd_card_free(card); snd_card_free(card);
return error; return error;
} }
} }
} }
if ((error = snd_card_register(card)) < 0) { error = snd_card_register(card);
if (error < 0) {
snd_card_free(card); snd_card_free(card);
return error; return error;
} }