49a4ec188f
We've had various reports of some legacy "probe the hardware" style platform drivers having nasty problems with hotplug support. The core issue is that those legacy drivers don't fully conform to the driver model. They assume a role that should be the responsibility of infrastructure code: creating device nodes. The "modprobe" step in hotplugging relies on drivers to have split those roles into different modules. The lack of this split causes the problems. When a driver creates nodes for devices that don't exist (sending a hotplug event), then exits (aborting one modprobe) before the "modprobe $MODALIAS" step completes (by failing, since it's in the middle of a modprobe), the result can be an endless loop of modprobe invocations ... badness. This fix uses the newish per-device flag controlling issuance of "add" events. (A previous version of this patch used a per-device "driver can hotplug" flag, which only scrubbed $MODALIAS from the environment rather than suppressing the entire hotplug event.) It also shrinks that flag to one bit, saving a word in "struct device". So the net of this patch is removing some nasty failures with legacy drivers, while retaining hotplug capability for the majority of platform drivers. Signed-off-by: David Brownell <dbrownell@users.sourceforge.net> Cc: Greg KH <gregkh@suse.de> Cc: Andres Salomon <dilinger@debian.org> Cc: Dominik Brodowski <linux@dominikbrodowski.net> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> |
||
|---|---|---|
| .. | ||
| Kconfig | ||
| Makefile | ||
| at91_cf.c | ||
| au1000_db1x00.c | ||
| au1000_generic.c | ||
| au1000_generic.h | ||
| au1000_pb1x00.c | ||
| au1000_xxs1500.c | ||
| cardbus.c | ||
| cirrus.h | ||
| cistpl.c | ||
| cs.c | ||
| cs_internal.h | ||
| ds.c | ||
| ds_internal.h | ||
| hd64465_ss.c | ||
| i82092.c | ||
| i82092aa.h | ||
| i82365.c | ||
| i82365.h | ||
| m8xx_pcmcia.c | ||
| m32r_cfc.c | ||
| m32r_cfc.h | ||
| m32r_pcc.c | ||
| m32r_pcc.h | ||
| o2micro.h | ||
| omap_cf.c | ||
| pcmcia_ioctl.c | ||
| pcmcia_resource.c | ||
| pd6729.c | ||
| pd6729.h | ||
| pxa2xx_base.c | ||
| pxa2xx_base.h | ||
| pxa2xx_lubbock.c | ||
| pxa2xx_mainstone.c | ||
| pxa2xx_sharpsl.c | ||
| ricoh.h | ||
| rsrc_mgr.c | ||
| rsrc_nonstatic.c | ||
| sa11xx_base.c | ||
| sa11xx_base.h | ||
| sa1100_assabet.c | ||
| sa1100_badge4.c | ||
| sa1100_cerf.c | ||
| sa1100_generic.c | ||
| sa1100_generic.h | ||
| sa1100_h3600.c | ||
| sa1100_jornada720.c | ||
| sa1100_neponset.c | ||
| sa1100_shannon.c | ||
| sa1100_simpad.c | ||
| sa1111_generic.c | ||
| sa1111_generic.h | ||
| soc_common.c | ||
| soc_common.h | ||
| socket_sysfs.c | ||
| tcic.c | ||
| tcic.h | ||
| ti113x.h | ||
| topic.h | ||
| vg468.h | ||
| vrc4171_card.c | ||
| vrc4173_cardu.c | ||
| vrc4173_cardu.h | ||
| yenta_socket.c | ||
| yenta_socket.h | ||