3269bb63eb
I have a Marvell board which has the same i2c hw block than mv64xxx, so I'm trying to use i2c-mv64xxx driver. But I get the following random oops at boot: Unable to handle kernel NULL pointer dereference at virtual address 00000002 Backtrace: [<c0397e4c>] (mv64xxx_i2c_intr+0x0/0x2b8) from [<c02879c4>] (__do_irq+0x4c/0x8c) [<c0287978>] (__do_irq+0x0/0x8c) from [<c0287c0c>] (do_level_IRQ+0x68/0xc0) r8 = C0501E08 r7 = 00000005 r6 = C0501E08 r5 = 00000005 r4 = C048BB78 [<c0287ba4>] (do_level_IRQ+0x0/0xc0) from [<c02885f8>] (asm_do_IRQ+0x50/0x134) r6 = C0449C78 r5 = F1020000 r4 = FFFFFFFF [<c02885a8>] (asm_do_IRQ+0x0/0x134) from [<c02869c4>] (__irq_svc+0x24/0x100) r8 = C1CAC400 r7 = 00000005 r6 = 00000002 r5 = F1020000 r4 = FFFFFFFF [<c0287efc>] (setup_irq+0x0/0x124) from [<c02880d0>] (request_irq+0xb0/0xd0) r7 = C041B2AC r6 = C0397E4C r5 = 00000000 r4 = 00000005 [<c0288020>] (request_irq+0x0/0xd0) from [<c03985f4>] (mv64xxx_i2c_probe+0x148/0x244) [<c03984ac>] (mv64xxx_i2c_probe+0x0/0x244) from [<c038bedc>] (platform_drv_probe+0x20/0x24) The oops is caused by a spurious interrupt that occurs when request_irq is called. mv64xxx_i2c_fsm() tries to read drv_data->msg, which is NULL. I noticed that hardware init is done after requesting irq. Thus any pending irq from previous hardware usage may cause this. The following patch fixes it: Signed-off-by: Maxime Bizon <mbizon@freebox.fr> Acked-by: Mark A. Greer <mgreer@mvista.com> Signed-off-by: Jean Delvare <khali@linux-fr.org> |
||
|---|---|---|
| .. | ||
| Kconfig | ||
| Makefile | ||
| i2c-ali15x3.c | ||
| i2c-ali1535.c | ||
| i2c-ali1563.c | ||
| i2c-amd756-s4882.c | ||
| i2c-amd756.c | ||
| i2c-amd8111.c | ||
| i2c-at91.c | ||
| i2c-au1550.c | ||
| i2c-au1550.h | ||
| i2c-elektor.c | ||
| i2c-hydra.c | ||
| i2c-i801.c | ||
| i2c-i810.c | ||
| i2c-ibm_iic.c | ||
| i2c-ibm_iic.h | ||
| i2c-iop3xx.c | ||
| i2c-iop3xx.h | ||
| i2c-isa.c | ||
| i2c-ixp4xx.c | ||
| i2c-ixp2000.c | ||
| i2c-mpc.c | ||
| i2c-mv64xxx.c | ||
| i2c-nforce2.c | ||
| i2c-ocores.c | ||
| i2c-omap.c | ||
| i2c-parport-light.c | ||
| i2c-parport.c | ||
| i2c-parport.h | ||
| i2c-pca-isa.c | ||
| i2c-piix4.c | ||
| i2c-pnx.c | ||
| i2c-powermac.c | ||
| i2c-prosavage.c | ||
| i2c-pxa.c | ||
| i2c-rpx.c | ||
| i2c-s3c2410.c | ||
| i2c-savage4.c | ||
| i2c-sibyte.c | ||
| i2c-sis96x.c | ||
| i2c-sis630.c | ||
| i2c-sis5595.c | ||
| i2c-stub.c | ||
| i2c-versatile.c | ||
| i2c-via.c | ||
| i2c-viapro.c | ||
| i2c-voodoo3.c | ||
| scx200_acb.c | ||
| scx200_i2c.c | ||