OpenSDV
/
original_kernel
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
original_kernel/kernel/irq
History
Thomas Gleixner cba6437a18 genirq/proc: Reject invalid affinity masks (again) 
Qian Cai reported that the WARN_ON() in the x86/msi affinity setting code,
which catches cases where the affinity setting is not done on the CPU which
is the current target of the interrupt, triggers during CPU hotplug stress
testing.

It turns out that the warning which was added with the commit addressing
the MSI affinity race unearthed yet another long standing bug.

If user space writes a bogus affinity mask, i.e. it contains no online CPUs,
then it calls irq_select_affinity_usr(). This was introduced for ALPHA in

  eee45269b0 ("[PATCH] Alpha: convert to generic irq framework (generic part)")

and subsequently made available for all architectures in

  1840475676 ("genirq: Expose default irq affinity mask (take 3)")

which introduced the circumvention of the affinity setting restrictions for
interrupt which cannot be moved in process context.

The whole exercise is bogus in various aspects:

  1) If the interrupt is already started up then there is absolutely
     no point to honour a bogus interrupt affinity setting from user
     space. The interrupt is already assigned to an online CPU and it
     does not make any sense to reassign it to some other randomly
     chosen online CPU.

  2) If the interupt is not yet started up then there is no point
     either. A subsequent startup of the interrupt will invoke
     irq_setup_affinity() anyway which will chose a valid target CPU.

So the only correct solution is to just return -EINVAL in case user space
wrote an affinity mask which does not contain any online CPUs, except for
ALPHA which has it's own magic sauce for this.

Fixes: 1840475676 ("genirq: Expose default irq affinity mask (take 3)")
Reported-by: Qian Cai <cai@lca.pw>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Tested-by: Qian Cai <cai@lca.pw>
Link: https://lkml.kernel.org/r/878sl8xdbm.fsf@nanos.tec.linutronix.de
 		2020-02-14 09:43:17 +01:00
..
Kconfig
…
Makefile
…
affinity.c
…
autoprobe.c
…
chip.c
…
cpuhotplug.c
…
debug.h
…
debugfs.c
…
devres.c
…
dummychip.c
…
generic-chip.c
…
handle.c
…
internals.h genirq/proc: Reject invalid affinity masks (again) 2020-02-14 09:43:17 +01:00
ipi.c
…
irq_sim.c
…
irqdesc.c
…
irqdomain.c
…
manage.c genirq/proc: Reject invalid affinity masks (again) 2020-02-14 09:43:17 +01:00
matrix.c
…
migration.c
…
msi.c
…
pm.c
…
proc.c genirq/proc: Reject invalid affinity masks (again) 2020-02-14 09:43:17 +01:00
resend.c
…
settings.h
…
spurious.c
…
timings.c
…