608e261968
The current generic bug implementation has a call to dump_stack() in case a WARN_ON(whatever) gets hit. Since report_bug(), which calls dump_stack(), gets called from an exception handler we can do better: just pass the pt_regs structure to report_bug() and pass it to show_regs() in case of a warning. This will give more debug informations like register contents, etc... In addition this avoids some pointless lines that dump_stack() emits, since it includes a stack backtrace of the exception handler which is of no interest in case of a warning. E.g. on s390 the following lines are currently always present in a stack backtrace if dump_stack() gets called from report_bug(): [<000000000001517a>] show_trace+0x92/0xe8) [<0000000000015270>] show_stack+0xa0/0xd0 [<00000000000152ce>] dump_stack+0x2e/0x3c [<0000000000195450>] report_bug+0x98/0xf8 [<0000000000016cc8>] illegal_op+0x1fc/0x21c [<00000000000227d6>] sysc_return+0x0/0x10 Acked-by: Jeremy Fitzhardinge <jeremy@goop.org> Acked-by: Haavard Skinnemoen <hskinnemoen@atmel.com> Cc: Andi Kleen <ak@suse.de> Cc: Kyle McMartin <kyle@parisc-linux.org> Cc: Paul Mackerras <paulus@samba.org> Cc: Paul Mundt <lethal@linux-sh.org> Cc: Martin Schwidefsky <schwidefsky@de.ibm.com> Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> |
||
|---|---|---|
| .. | ||
| acpi | ||
| cpu | ||
| .gitignore | ||
| Makefile | ||
| alternative.c | ||
| apic.c | ||
| apm.c | ||
| asm-offsets.c | ||
| bootflag.c | ||
| cpuid.c | ||
| crash.c | ||
| crash_dump.c | ||
| doublefault.c | ||
| e820.c | ||
| early_printk.c | ||
| efi.c | ||
| efi_stub.S | ||
| entry.S | ||
| head.S | ||
| hpet.c | ||
| i386_ksyms.c | ||
| i387.c | ||
| i8237.c | ||
| i8253.c | ||
| i8259.c | ||
| init_task.c | ||
| io_apic.c | ||
| ioport.c | ||
| irq.c | ||
| kprobes.c | ||
| ldt.c | ||
| legacy_serial.c | ||
| machine_kexec.c | ||
| mca.c | ||
| microcode.c | ||
| module.c | ||
| mpparse.c | ||
| msr.c | ||
| nmi.c | ||
| numaq.c | ||
| paravirt.c | ||
| pci-dma.c | ||
| pcspeaker.c | ||
| process.c | ||
| ptrace.c | ||
| quirks.c | ||
| reboot.c | ||
| reboot_fixups.c | ||
| relocate_kernel.S | ||
| scx200.c | ||
| setup.c | ||
| sigframe.h | ||
| signal.c | ||
| smp.c | ||
| smpboot.c | ||
| smpcommon.c | ||
| srat.c | ||
| summit.c | ||
| sys_i386.c | ||
| syscall_table.S | ||
| sysenter.c | ||
| time.c | ||
| topology.c | ||
| trampoline.S | ||
| traps.c | ||
| tsc.c | ||
| tsc_sync.c | ||
| vm86.c | ||
| vmi.c | ||
| vmiclock.c | ||
| vmlinux.lds.S | ||
| vsyscall-int80.S | ||
| vsyscall-note.S | ||
| vsyscall-sigreturn.S | ||
| vsyscall-sysenter.S | ||
| vsyscall.S | ||
| vsyscall.lds.S | ||