OpenSDV
/
original_kernel
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
original_kernel/fs
History
Gao Xiang cc4b2dd95f erofs: fix infinite loop due to a race of filling compressed_bvecs 
I encountered a race issue after lengthy (~594647 secs) stress tests on
a 64k-page arm64 VM with several 4k-block EROFS images.  The timing
is like below:

z_erofs_try_inplace_io                  z_erofs_fill_bio_vec
  cmpxchg(&compressed_bvecs[].page,
          NULL, ..)
                                        [access bufvec]
  compressed_bvecs[] = *bvec;

Previously, z_erofs_submit_queue() just accessed bufvec->page only, so
other fields in bufvec didn't matter.  After the subpage block support
is landed, .offset and .end can be used too, but filling bufvec isn't
an atomic operation which can cause inconsistency.

Let's use a spinlock to keep the atomicity of each bufvec.  More
specifically, just reuse the existing spinlock `pcl->obj.lockref.lock`
since it's rarely used (also it takes a short time if even used) as long
as the pcluster has a reference.

Fixes: 192351616a ("erofs: support I/O submission for sub-page compressed blocks")
Signed-off-by: Gao Xiang <hsiangkao@linux.alibaba.com>
Reviewed-by: Yue Hu <huyue2@coolpad.com>
Reviewed-by: Sandeep Dhavale <dhavale@google.com>
Link: https://lore.kernel.org/r/20240125120039.3228103-1-hsiangkao@linux.alibaba.com
 		2024-01-26 18:07:36 +08:00
..
9p
…
adfs
…
affs
…
afs vfs-6.8.netfs 2024-01-19 09:10:23 -08:00
autofs dcache stuff for this cycle 2024-01-11 20:11:35 -08:00
bcachefs More bcachefs updates for 6.7-rc1 2024-01-21 14:01:12 -08:00
befs
…
bfs misc cleanups (the part that hadn't been picked by individual fs trees) 2024-01-11 20:23:50 -08:00
btrfs for-6.8/block-2024-01-08 2024-01-11 13:58:04 -08:00
cachefiles vfs-6.8.netfs 2024-01-19 09:10:23 -08:00
ceph Assorted CephFS fixes and cleanups with nothing standing out. 2024-01-19 09:58:55 -08:00
coda dcache stuff for this cycle 2024-01-11 20:11:35 -08:00
configfs
…
cramfs
…
crypto
…
debugfs
…
devpts
…
dlm
…
ecryptfs fix directory locking scheme on rename 2024-01-11 20:00:22 -08:00
efivarfs
…
efs
…
erofs erofs: fix infinite loop due to a race of filling compressed_bvecs 2024-01-26 18:07:36 +08:00
exfat
…
exportfs
…
ext2 fix directory locking scheme on rename 2024-01-11 20:00:22 -08:00
ext4 misc cleanups (the part that hadn't been picked by individual fs trees) 2024-01-11 20:23:50 -08:00
f2fs f2fs: fix double free of f2fs_sb_info 2024-01-12 18:55:09 -08:00
fat
…
freevxfs
…
fuse
…
gfs2
…
hfs
…
hfsplus
…
hostfs
…
hpfs
…
hugetlbfs
…
iomap
…
isofs
…
jbd2
…
jffs2
…
jfs
…
kernfs Revert "kernfs: convert kernfs_idr_lock to an irq safe raw spinlock" 2024-01-11 11:51:27 +01:00
lockd sysctl-6.8-rc1 2024-01-10 17:44:36 -08:00
minix minixfs kmap_local_page() switchover and related fixes - very similar to sysv series. 2024-01-11 19:54:18 -08:00
netfs vfs-6.8.netfs 2024-01-19 09:10:23 -08:00
nfs vfs-6.8.netfs 2024-01-19 09:10:23 -08:00
nfs_common
…
nfsd misc cleanups (the part that hadn't been picked by individual fs trees) 2024-01-11 20:23:50 -08:00
nilfs2 misc cleanups (the part that hadn't been picked by individual fs trees) 2024-01-11 20:23:50 -08:00
nls
…
notify dcache stuff for this cycle 2024-01-11 20:11:35 -08:00
ntfs sysctl-6.8-rc1 2024-01-10 17:44:36 -08:00
ntfs3
…
ocfs2 misc cleanups (the part that hadn't been picked by individual fs trees) 2024-01-11 20:23:50 -08:00
omfs
…
openpromfs
…
orangefs
…
overlayfs dcache stuff for this cycle 2024-01-11 20:11:35 -08:00
proc 17 hotfixes. 10 address post-6.7 issues and the other 7 are cc:stable. 2024-01-17 09:31:36 -08:00
pstore
…
qnx4
…
qnx6
…
quota sysctl-6.8-rc1 2024-01-10 17:44:36 -08:00
ramfs
…
reiserfs misc cleanups (the part that hadn't been picked by individual fs trees) 2024-01-11 20:23:50 -08:00
romfs
…
smb Various smb client fixes, including multichannel and for SMB3.1.1 POSIX extensions 2024-01-20 16:48:07 -08:00
squashfs
…
sysfs
…
sysv
…
tracefs eventfs: Use kcalloc() instead of kzalloc() 2024-01-16 17:52:33 -05:00
ubifs
…
udf misc cleanups (the part that hadn't been picked by individual fs trees) 2024-01-11 20:23:50 -08:00
ufs
…
unicode
…
vboxsf
…
verity Networking changes for 6.8. 2024-01-11 10:07:29 -08:00
xfs Bug fixes for 6.8: 2024-01-19 09:57:08 -08:00
zonefs misc cleanups (the part that hadn't been picked by individual fs trees) 2024-01-11 20:23:50 -08:00
Kconfig vfs-6.8.netfs 2024-01-19 09:10:23 -08:00
Kconfig.binfmt
…
Makefile vfs-6.8.netfs 2024-01-19 09:10:23 -08:00
aio.c sysctl-6.8-rc1 2024-01-10 17:44:36 -08:00
anon_inodes.c
…
attr.c
…
backing-file.c
…
bad_inode.c
…
binfmt_elf.c
…
binfmt_elf_fdpic.c
…
binfmt_elf_test.c
…
binfmt_flat.c
…
binfmt_misc.c
…
binfmt_script.c
…
buffer.c
…
char_dev.c
…
compat_binfmt_elf.c
…
coredump.c
…
d_path.c
…
dax.c
…
dcache.c dcache stuff for this cycle 2024-01-11 20:11:35 -08:00
direct-io.c
…
drop_caches.c
…
eventfd.c
…
eventpoll.c
…
exec.c execve: open the executable file before doing anything else 2024-01-20 12:15:43 -08:00
fcntl.c
…
fhandle.c
…
file.c
…
file_table.c dcache stuff for this cycle 2024-01-11 20:11:35 -08:00
filesystems.c
…
fs-writeback.c
…
fs_context.c
…
fs_parser.c
…
fs_pin.c
…
fs_struct.c
…
fs_types.c
…
fsopen.c
…
init.c
…
inode.c fix directory locking scheme on rename 2024-01-11 20:00:22 -08:00
internal.h dcache stuff for this cycle 2024-01-11 20:11:35 -08:00
ioctl.c
…
kernel_read_file.c
…
libfs.c dcache stuff for this cycle 2024-01-11 20:11:35 -08:00
locks.c
…
mbcache.c
…
mnt_idmapping.c
…
mount.h
…
mpage.c
…
namei.c fix buggered locking in bch2_ioctl_subvolume_destroy() 2024-01-12 18:04:01 -08:00
namespace.c fs: rework listmount() implementation 2024-01-13 13:06:25 +01:00
nsfs.c
…
open.c
…
pipe.c sysctl-6.8-rc1 2024-01-10 17:44:36 -08:00
pnode.c
…
pnode.h
…
posix_acl.c
…
proc_namespace.c
…
read_write.c
…
readdir.c
…
remap_range.c
…
select.c
…
seq_file.c
…
signalfd.c
…
splice.c
…
stack.c
…
stat.c
…
statfs.c
…
super.c fscrypt updates for 6.8 2024-01-10 10:24:49 -08:00
sync.c
…
sysctls.c
…
timerfd.c
…
userfaultfd.c Generic: 2024-01-17 13:03:37 -08:00
utimes.c
…
xattr.c
…