original_kernel/arch/um
Willem de Bruijn fd3a886258 net: in virtio_net_hdr only add VLAN_HLEN to csum_start if payload holds vlan
Tun, tap, virtio, packet and uml vector all use struct virtio_net_hdr
to communicate packet metadata to userspace.

For skbuffs with vlan, the first two return the packet as it may have
existed on the wire, inserting the VLAN tag in the user buffer.  Then
virtio_net_hdr.csum_start needs to be adjusted by VLAN_HLEN bytes.

Commit f09e2249c4 ("macvtap: restore vlan header on user read")
added this feature to macvtap. Commit 3ce9b20f19 ("macvtap: Fix
csum_start when VLAN tags are present") then fixed up csum_start.

Virtio, packet and uml do not insert the vlan header in the user
buffer.

When introducing virtio_net_hdr_from_skb to deduplicate filling in
the virtio_net_hdr, the variant from macvtap which adds VLAN_HLEN was
applied uniformly, breaking csum offset for packets with vlan on
virtio and packet.

Make insertion of VLAN_HLEN optional. Convert the callers to pass it
when needed.

Fixes: e858fae2b0 ("virtio_net: use common code for virtio_net_hdr and skb GSO conversion")
Fixes: 1276f24eee ("packet: use common code for virtio_net_hdr and skb GSO conversion")
Signed-off-by: Willem de Bruijn <willemb@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2018-06-07 16:15:38 -04:00
..
configs
drivers net: in virtio_net_hdr only add VLAN_HLEN to csum_start if payload holds vlan 2018-06-07 16:15:38 -04:00
include time: Add an asm-generic/compat.h file 2018-04-19 13:28:51 +02:00
kernel signal/um: More carefully relay signals in relay_signal. 2018-04-28 08:46:49 -05:00
os-Linux um: Compile with modern headers 2018-03-29 22:15:12 +02:00
scripts
.gitignore
Kconfig.char
Kconfig.common kconfig: reference environment variables directly and remove 'option env=' 2018-05-29 03:28:58 +09:00
Kconfig.debug
Kconfig.net High Performance UML Vector Network Driver 2018-02-19 19:38:51 +01:00
Kconfig.rest
Kconfig.um
Makefile
Makefile-os-Linux
Makefile-skas